-
Notifications
You must be signed in to change notification settings - Fork 556
[BMS] StageNet with Attention #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8895b0c to
e9b34e5
Compare
jhnwu3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add it to the docs/?
I think it makes sense to stack attention between each RNN pass. So it's probably good enough here. We just need to rename the StageNet layer and also check that we can pull out both the attention scores and its gradients for the attn-grad visualizations.
jhnwu3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Contributor: Yongda Fan ([email protected])
Contribution Type: Model
Description
Create a new model StageNet with Attention, with MHA layers inserted between SA-LSTM and SA-CNN.
Files to Review
pyhealth/models/stagenet_mha.py
tests/core/test_stagenet_mha.py